[PROF-11305] Enable memory leak testing with ASAN, try 3 #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**
This PR tries again to re-enable the memory leak testing with
AddressSanitizer ("ASAN").
We previously had disabled it since it was failing due to an unrelated
issue (specifically, the asan builds are based on Ruby master, and
Ruby master was slightly incompatible with the profiler until the
`datadog-ruby_core_source` 3.3.7 brought a newer set of headers).
**Motivation:**
The ASAN tool is quite powerful at detecting memory issues and
other problems in native extensions, so if we can keep it running
it can help flag issues before they make it to our customers.
**Additional Notes:**
We can always disable again later if needed.
Hopefully once Ruby 3.4 stable is out, we can see if it's possible
to have a "stable ASAN" build that's not based off of ruby master,
and thus is a bit more predictable.
**How to test the change?**
Validate the "Test for memory leaks > test asan" CI step is
running and passing.
github-actions
bot
added
the
dev/github
Datadog ReportBranch report: ✅ 0 Failed, 22084 Passed, 1459 Skipped, 5m 44.77s Total Time |
|
#4113 is the PR that disabled the check |
BenchmarksBenchmark execution time: 2024-12-16 18:15:13 Comparing candidate commit 4fe11cf in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
p-datadog
approved these changes
Dec 16, 2024
|
Merged this one! The "Datadog Software Composition Analysis / Datadog SBOM Generation and Upload (push)" issue is unrelated and is being tracked separately. |
ivoanjo
added
dev/testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tries again to re-enable the memory leak testing with AddressSanitizer ("ASAN").
We previously had disabled it since it was failing due to an unrelated issue (specifically, the asan builds are based on Ruby master, and Ruby master was slightly incompatible with the profiler until the
datadog-ruby_core_source3.3.7 brought a newer set of headers).Motivation:
The ASAN tool is quite powerful at detecting memory issues and other problems in native extensions, so if we can keep it running it can help flag issues before they make it to our customers.
Change log entry
None.
Additional Notes:
We can always disable again later if needed.
Hopefully once Ruby 3.4 stable is out, we can see if it's possible to have a "stable ASAN" build that's not based off of ruby master, and thus is a bit more predictable.
How to test the change?
Validate the "Test for memory leaks > test asan" CI step is running and passing.