-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal: Add span events native serialization #4218
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22112 Passed, 1458 Skipped, 5m 47.08s Total Time |
4287f6b
to
f79fd65
Compare
BenchmarksBenchmark execution time: 2024-12-11 20:21:27 Comparing candidate commit afce240 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4218 +/- ##
========================================
Coverage 97.75% 97.76%
========================================
Files 1357 1357
Lines 82130 82238 +108
Branches 4174 4205 +31
========================================
+ Hits 80288 80398 +110
+ Misses 1842 1840 -2 ☔ View full report in Codecov by Sentry. |
Add native serialization for the
Datadog::Tracing::SpanEvent
object, when serialized as MessagePack.This code disabled today, through the
native_events_supported
variable, so this PR is just adding the serialization code that will be activated in a future PR.Change log entry
None
Additional Notes:
I've also changed the returned keys from
to_hash
to have String keys, instead of Symbols from before, because both the MessagePack and JSON serialization will convert all this Symbols to Strings immediately. Making this change avoids an unnecessary Symbol -> String conversion.How to test the change?
All changes are tested, as well as some improved testing for existing Span Events methods.