Clean Ruby 2.x Gemfiles #4212
Merged
Clean Ruby 2.x Gemfiles #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-12-11 16:04:05 Comparing candidate commit 57c4e2c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4212 +/- ##
==========================================
- Coverage 97.76% 97.76% -0.01%
==========================================
Files 1357 1357
Lines 82130 82130
Branches 4174 4174
==========================================
- Hits 80298 80294 -4
- Misses 1832 1836 +4 ☔ View full report in Codecov by Sentry. |
p-datadog
approved these changes
Dec 10, 2024
sarahchen6
force-pushed
the
sarahchen6/clean-2.x-gemfiles
branch
from
2e53c99 to
ae88baa
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22079 Passed, 1458 Skipped, 6m 13.95s Total Time |
sarahchen6
force-pushed
the
sarahchen6/clean-2.x-gemfiles
branch
from
02791b7 to
a8619ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes
ifstatements and alphabetizesruby-2.x.gemfiles.Motivation:
Since gemfiles are no longer symlinked, we can begin removing
ifstatements and generally cleaning each file.Change log entry
None.
Additional Notes:
N/A
How to test the change?
Green CI.