-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROF-10967] Fix missing suppressions after PR 4161 got merged #4162
Conversation
Looks like a method got renamed and our previous suppressions stopped working.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4162 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 1353 1353
Lines 81796 81796
Branches 4143 4143
=======================================
+ Hits 79981 79984 +3
+ Misses 1815 1812 -3 ☔ View full report in Codecov by Sentry. |
Aargh what a minefield, this failed again because Ruby 3.4.0-preview2 ships a buggy rubygems... Let me try to put a workaround in place. |
Got bitten by rubygems/rubygems#8108 again.
And we have a green build! https://github.com/DataDog/dd-trace-rb/actions/runs/12032142202/job/33543279424?pr=4162 |
BenchmarksBenchmark execution time: 2024-11-26 14:09:58 Comparing candidate commit d1e2d72 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
…r-4161 [PROF-10967] Fix missing suppressions after PR 4161 got merged
What does this PR do?
This PR updates the suppressions file to make the "Test for memory leaks" check pass, after #4161 broke it by upgrading the Ruby version used to run this check.
Motivation:
Make sure master is squeaky clean.
Change log entry
(Not relevant to customers)
Additional Notes:
This was supposed to go together with #4161, but even though the "Test for memory leaks" failed, the auto-merge still merged my PR while I was preparing this extra commit to make it pass CI.
How to test the change?
Validate the "Test for memory leaks", CI validation passes again.