Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-10967] Fix missing suppressions after PR 4161 got merged #4162

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Nov 26, 2024

What does this PR do?

This PR updates the suppressions file to make the "Test for memory leaks" check pass, after #4161 broke it by upgrading the Ruby version used to run this check.

Motivation:

Make sure master is squeaky clean.

Change log entry

(Not relevant to customers)

Additional Notes:

This was supposed to go together with #4161, but even though the "Test for memory leaks" failed, the auto-merge still merged my PR while I was preparing this extra commit to make it pass CI.

How to test the change?

Validate the "Test for memory leaks", CI validation passes again.

Looks like a method got renamed and our previous suppressions stopped
working.
@ivoanjo ivoanjo requested a review from a team as a code owner November 26, 2024 13:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (c5232cb) to head (12d61d0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4162   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files        1353     1353           
  Lines       81796    81796           
  Branches     4143     4143           
=======================================
+ Hits        79981    79984    +3     
+ Misses       1815     1812    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivoanjo
Copy link
Member Author

ivoanjo commented Nov 26, 2024

Aargh what a minefield, this failed again because Ruby 3.4.0-preview2 ships a buggy rubygems... Let me try to put a workaround in place.

@ivoanjo
Copy link
Member Author

ivoanjo commented Nov 26, 2024

@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2024

Benchmarks

Benchmark execution time: 2024-11-26 14:09:58

Comparing candidate commit d1e2d72 in PR branch ivoanjo/fix-suppresions-after-pr-4161 with baseline commit c5232cb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@ivoanjo ivoanjo merged commit 3f8615b into master Nov 26, 2024
287 of 289 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/fix-suppresions-after-pr-4161 branch November 26, 2024 14:18
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 26, 2024
@ivoanjo ivoanjo added dev/testing Involves testing processes (e.g. RSpec) profiling Involves Datadog profiling dev/internal Other internal work that does not need to be included in the changelog labels Nov 28, 2024
TonyCTHsu pushed a commit that referenced this pull request Nov 28, 2024
…r-4161

[PROF-10967] Fix missing suppressions after PR 4161 got merged
@ivoanjo ivoanjo modified the milestones: 2.8.0, 2.7.1 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/testing Involves testing processes (e.g. RSpec) profiling Involves Datadog profiling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants