-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry: Deduplicate log entries #4154
base: master
Are you sure you want to change the base?
Conversation
BenchmarksBenchmark execution time: 2024-12-13 22:11:08 Comparing candidate commit 35c01fb in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
Thank you for updating Change log entry section 👏 Visited at: 2024-12-13 19:02:47 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 22116 Passed, 1457 Skipped, 5m 42.69s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4154 +/- ##
========================================
Coverage 97.75% 97.75%
========================================
Files 1355 1355
Lines 82007 82192 +185
Branches 4207 4217 +10
========================================
+ Hits 80164 80349 +185
Misses 1843 1843 ☔ View full report in Codecov by Sentry. |
@@ -41,6 +41,18 @@ def to_h | |||
} | |||
end | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In implementing equality for all the Datadog::Core::Telemetry::Event
in event.rb
, the Datadog::Core::Telemetry::Metric
objects also needed their equality implemented since some events contain metrics, which need to be compared.
This PR removes duplicate telemetry logs sent within the same batch (currently 10s). The number of occurrences is captured in the new
count
field for theLog
telemetry event, so we can know how many events were removed as duplicated.Change log entry
None