Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unintentional libddwaf require #4078

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Strech
Copy link
Member

@Strech Strech commented Nov 6, 2024

What does this PR do?

Remove unintentional require libddwaf library from the Context class.

Motivation:

This was a mistake which slipped through the review and coding.
Related: #4077

Change log entry

Yes.
Fix: Remove unnecessary require of libddwaf library which may cause crashing.

Additional Notes:

Probably this should be released as 2.5.1 patch release

How to test the change?

Ideally just CI.

@Strech Strech requested a review from a team as a code owner November 6, 2024 21:13
@Strech Strech added bug Involves a bug appsec Application Security monitoring product labels Nov 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (25d6fb8) to head (20145a5).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4078      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files        1338     1338              
  Lines       80249    80252       +3     
  Branches     4016     4017       +1     
==========================================
- Hits        78434    78433       -1     
- Misses       1815     1819       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Strech Strech merged commit e24d034 into master Nov 6, 2024
265 of 266 checks passed
@Strech Strech deleted the fix-libddwaf-unconditional-require branch November 6, 2024 21:37
@github-actions github-actions bot added this to the 2.6.0 milestone Nov 6, 2024
@Strech Strech mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product bug Involves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants