Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing system tests #4026

Closed
wants to merge 3 commits into from
Closed

fix failing system tests #4026

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1795b5
dont use docker arg if running CROSSED_TRACING_LIBRARIES tests
wconti27 Oct 24, 2024
62a672b
change
wconti27 Oct 24, 2024
4840d30
change ref
wconti27 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/system-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 'DataDog/system-tests'
ref: ${{ env.ST_REF }}
ref: conti/set-aws-env-on-docker-runner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would mean that system-tests would not run on the main system-tests branch but on conti/set-aws-env-on-docker-runner branch. If that's intended you can replace ST_REF: main at line 14 but this should not be merged in dd-trace-rb master, as this is only a way to use a system-tests branch (while waiting for it to be merged in main) on your branch/PR and this should always be set to main on dd-trace-rb masterbranch

persist-credentials: false
- name: Pull runner image
run: |
Expand Down
Loading