Add ActiveSupport::Notifications::Event helper #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
delner
force-pushed
the
refactor/active_support_notifications_event_helper
branch
from
a085d48
to
24f4db9
Compare
palazzem
approved these changes
Apr 16, 2018
sullimander
added a commit
to sullimander/dd-trace-rb
that referenced
this pull request
Apr 24, 2018
Updated to use the ActiveSupport::Notifications::Event helper per DataDog#400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
Datadog::Contrib::ActiveSupport::Notifications::Eventhelper, which provides a pattern for modeling instrumentation events for ActiveSupport::Notifications. The goal of this is to make use of the Subscriber API a little cleaner, easier to use, and more extensible.It also refactors ActiveRecord and Racecar to implement this pattern.