Add ActiveSupport::Notifications subscription error handling #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd refactors for subscription.
palazzem
suggested changes
Apr 9, 2018
| def run(span, name, id, payload) | ||
| run!(span, name, id, payload) | ||
| rescue StandardError => e | ||
| Datadog::Tracer.log.error("ActiveSupport::Notifications handler for '#{name}' failed: #{e.message}") |
There was a problem hiding this comment.
In a high throughput environment we may spam logs too much. Can you write using the debug mode so without any config change we're sure to not write our failures?
| begin | ||
| callback.call(event, key, *args) | ||
| rescue StandardError => e | ||
| Datadog::Tracer.log.error( |
There was a problem hiding this comment.
I think the same applies here
| @@ -98,7 +98,7 @@ def initialize(options = {}) | |||
| @provider = options.fetch(:context_provider, Datadog::DefaultContextProvider.new) | |||
| @provider ||= Datadog::DefaultContextProvider.new # @provider should never be nil | |||
|
|
|||
| @context_flush = Datadog::ContextFlush.new(options) if options[:partial_flush] | |||
| @context_flush = options[:partial_flush] ? Datadog::ContextFlush.new(options) : nil | |||
palazzem
approved these changes
Apr 9, 2018
delner
deleted the
bugfix/active_support_notifications_missing_error_handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two bugs:
ensure_clean_context!wasn't working; fixes use oftracer.Also adds support for
callfor 3.x ActiveSupport implementations and refactors the internals of Subscription a little (should improve extensibility.)