Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest group for integration #3916

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 17, 2024

What does this PR do?

This PR provides a helper build_coverage_matrix to expand appraisal group definition, which generates a latest group without version constraint.

Also running task bundle exec rake edge:latest can target and update this group across major versions.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/edge-build-coverage branch from 3680662 to 24f44ff Compare September 17, 2024 11:12
@TonyCTHsu TonyCTHsu added this to the 2.4.0 milestone Sep 17, 2024
@TonyCTHsu TonyCTHsu added the dev/testing Involves testing processes (e.g. RSpec) label Sep 17, 2024
@github-actions github-actions bot removed the dev/testing Involves testing processes (e.g. RSpec) label Sep 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (8f9f58c) to head (ee52ac1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
- Coverage   97.85%   97.85%   -0.01%     
==========================================
  Files        1285     1285              
  Lines       76951    76951              
  Branches     3789     3789              
==========================================
- Hits        75302    75300       -2     
- Misses       1649     1651       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 17, 2024 11:49
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 17, 2024 11:49
@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Sep 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2024

Benchmarks

Benchmark execution time: 2024-09-17 14:32:22

Comparing candidate commit ee52ac1 in PR branch tonycthsu/edge-build-coverage with baseline commit 8f9f58c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu enabled auto-merge September 18, 2024 09:20
@TonyCTHsu TonyCTHsu merged commit 63423f9 into master Sep 18, 2024
185 of 190 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/edge-build-coverage branch September 18, 2024 09:31
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants