Extract #ensure_clean_context! from ActiveSupport::Notifications subscription #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensure_clean_context!
delner
force-pushed
the
bugfix/active_support_notifications_ensure_clean_context
branch
from
09c355b
to
c65431b
Compare
palazzem
approved these changes
Apr 5, 2018
delner
deleted the
bugfix/active_support_notifications_ensure_clean_context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we extracted
Datadog::Contrib::ActiveSupport::Notifications::Subscriptionfrom our Racecar integration, we migrated aensure_clean_context!method along with it. This was in error; this method is specific to Racecar, and is causing side-effects for other subscription based integrations.This pull request removes
ensure_clean_context!from the subscription, and replaces it withbefore_trace/after_tracecallbacks. Racecar then uses this new set of callbacks to re-implementensure_clean_context!in its own patcher.Should unblock #340.