-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ostruct to Gemfile for Ruby >= 3.3.5 #3890
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3890 +/- ##
=======================================
Coverage 97.85% 97.86%
=======================================
Files 1277 1277
Lines 76392 76392
Branches 3744 3744
=======================================
+ Hits 74757 74764 +7
+ Misses 1635 1628 -7 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-09-05 10:32:41 Comparing candidate commit f4c0c4e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
Gemfile
Outdated
@@ -62,6 +62,8 @@ if RUBY_VERSION >= '2.6.0' | |||
gem 'rubocop-rspec', ['~> 2.20', '< 2.21'], require: false | |||
end | |||
|
|||
gem 'ostruct' if RUBY_VERSION >= '3.3.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I suggest maybe doing >= 3.3
instead of 3.3.5
.
My thinking is that we're not very consistent in upgrading to point releases in our different test/development environments, and on the off chance we have some weird issue from this, it may be a bit harder to diagnose if only some of the 3.3 series gets this new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed here 261b590 (force pushed)
fd8bc2a
to
ea38b4d
Compare
This addresses the deprecation warning that `ostruct` will not be part of standard library since ruby 3.5
ea38b4d
to
4e51340
Compare
This looks good... But there's one more missing piece. Specifically, this will affect the appraisal gemfiles for 3.3 rubies. Supposedly we have a Github Action that should trigger to update this, but the trigger condition is buggy (found this recently) and sometimes doesn't trigger when it should (e.g. in this PR): https://github.com/DataDog/dd-trace-rb/actions/runs/10716765010/job/29715426163 . As a quick workaround, I've opened another PR (#3892) to force the GHA to trigger: https://github.com/DataDog/dd-trace-rb/actions/runs/10717020845/job/29715869065 . It's currently running, and once it's done, we can cherry-pick that change on top of this PR. |
@ivoanjo thanks! I haven't thought about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
No worries! Our setup is quite complex to try to cover all the testing we need, and it has a few gaps that we haven't yet plugged :) I've cherry-picked the commit generated by GHA, I think we're good to go once CI is green and beautiful :) |
* master: add missing permissions for add-milestone gha workflow Improve brittle assertion Revert "Merge pull request DataDog#3890 from DataDog/fix-ostruct-deprecation-warning" fix lint error test for patched tracer_version add a comment about tracer_version patch fix typechecks and replace + with - in extended version add ci-X.Y.Z to the tracer_version if datadog-ci is present and CI mode is enabled
This addresses the deprecation warning that
ostruct
will not be part of standard library since ruby 3.5What does this PR do?
This PR adds
ostruct
gem to Gemfile for Ruby version 3.3.5 and higher.Motivation:
Failing tests due to a deprecation warning:
https://github.com/DataDog/dd-trace-rb/actions/runs/10703793866/job/29675192240?pr=3887