Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable persist-credentials for actions/checkout in system-tests #3860

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

cbeauchesne
Copy link
Contributor

What does this PR do?
Add persist-credentials: false to checkout jobs in system-tests workflow

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Aug 22, 2024
@cbeauchesne cbeauchesne marked this pull request as ready for review August 22, 2024 08:32
@cbeauchesne cbeauchesne requested a review from a team as a code owner August 22, 2024 08:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (3da4cfd) to head (03b140e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3860      +/-   ##
==========================================
+ Coverage   97.85%   97.86%   +0.01%     
==========================================
  Files        1271     1271              
  Lines       75975    75975              
  Branches     3739     3739              
==========================================
+ Hits        74345    74355      +10     
+ Misses       1630     1620      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbeauchesne
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 22, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@cbeauchesne
Copy link
Contributor Author

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Aug 22, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@pr-commenter
Copy link

pr-commenter bot commented Aug 22, 2024

Benchmarks

Benchmark execution time: 2024-08-22 09:04:55

Comparing candidate commit 03b140e in PR branch cbeauchesne/persist-credentials with baseline commit 3da4cfd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu merged commit 8aee247 into master Aug 22, 2024
186 of 187 checks passed
@TonyCTHsu TonyCTHsu deleted the cbeauchesne/persist-credentials branch August 22, 2024 10:24
@github-actions github-actions bot added this to the 2.3.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation mergequeue-status: removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants