Emit log message for incompatible Lograge setup #3839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2012
This PR emits an error-level log message when the
lograge
gem is used with Rails tagged logging, which is configured by default in Rails since Rails 5.We can't practically fix the issue here in
dd-trace-rb
, since the issue is a log formatting conflict betweenlograge
andRails
.The reason this affects APM Tracing is because it breaks trace-log correlation.
The only alternatives are to either: disable Rails tagged logging; or not use
lograge
.The investigation and suggest alternatives are well documented here: #2012 (comment)