Re-add query string to http.url tag #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
force-pushed
the
bugfix/readd_query_string_to_http_url
branch
from
d62b4d8
to
3f2d44f
Compare
|
This pull request needs a test added still. |
palazzem
previously approved these changes
Feb 21, 2018
| # REQUEST_URI is only available depending on what web server is running though. | ||
| # So when its not available, we want the original, unmutated PATH_INFO, which | ||
| # is just the relative path without query strings. | ||
| url = env['REQUEST_URI'] || original_env['PATH_INFO'] |
There was a problem hiding this comment.
let's keep the behavior as before, we'll re-evaluate keeping or not the query string later
There was a problem hiding this comment.
This change implements the query string behavior as it was prior to #351, plus a small bugfix.
delner
force-pushed
the
bugfix/readd_query_string_to_http_url
branch
from
c65d6e7
to
60069cd
Compare
delner
force-pushed
the
bugfix/readd_query_string_to_http_url
branch
from
60069cd
to
a66ec42
Compare
Merged
p-lambert
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recent pull request #351 effectively removed query strings from
http.urlin the process of trying to address an edge case concerning exception handling. We don't want to change this behavior right now; this pull request partially reverts the change, while retaining a secondary preference for the original PATH_INFO, which should retain the bugfix from the previous PR.