Bump debase-ruby_core_source dependency to 3.3.1 #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR bumps our dependency on `debase-ruby_core_source` to version 3.3.1. This version includes the headers for the recently-released Ruby 3.3.0; up until now we were supporting that Ruby version using a copy of the headers from the preview release. **Motivation:** Use up-to-date headers for profiling on Ruby 3.3.0. **Additional Notes:** I've updated the appraisal gemfiles as well. I previously tried to upgrade the gem dependency to 3.3.0 but that version was affected by ruby-debug/debase-ruby_core_source#10 . **How to test the change?** Validate that CI is green.
anmarchenko
approved these changes
Jan 9, 2024
AlexJF
approved these changes
Jan 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3373 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 1254 1254
Lines 73347 73347
Branches 3437 3437
=======================================
+ Hits 72059 72061 +2
+ Misses 1288 1286 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR bumps our dependency on
debase-ruby_core_sourceto version 3.3.1. This version includes the headers for the recently-released Ruby 3.3.0; up until now we were supporting that Ruby version using a copy of the headers from the preview release.Motivation:
Use up-to-date headers for profiling on Ruby 3.3.0.
Additional Notes:
I've updated the appraisal gemfiles as well.
I previously tried to upgrade the gem dependency to 3.3.0 but that version was affected by ruby-debug/debase-ruby_core_source#10 .
How to test the change?
Validate that CI is green.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Fixes #3372