Remove Datadog::Tracing::Contrib::HTTP::Instrumentation.after_request
#3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
changed the title
Datadog::Tracing::Contrib::HTTP::Instrumentation.after_request
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3367 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 1248 1248
Lines 72285 72257 -28
Branches 3391 3384 -7
=======================================
- Hits 70920 70894 -26
+ Misses 1365 1363 -2 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
approved these changes
Jan 8, 2024
ekump
approved these changes
Jan 9, 2024
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
The undocumented HTTP hook
Datadog::Tracing::Contrib::HTTP::Instrumentation.after_requesthas been removed. This hook was intrusive, only restricted to thenet/httpclient, and was not generalizable to other HTTP client gems.If you require this hook, please open a "Feature request" stating your use case so we can asses how to best support it.
Additional Notes:
We are open to adding similar capabilities in the future, but we should asses the concrete user needs for such hook.
How to test the change?
All changes are covered by unit testing. In this case, the tests are removed due to the removal of the feature.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!