Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add the Monkey as a deprecated module #336

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Re-add the Monkey as a deprecated module #336

merged 1 commit into from
Feb 5, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Feb 2, 2018 •
edited
Loading

#322 removed Datadog::Monkey with version 0.11.1.

To address some backwards compatibility issues, this pull request reintroduces the Datadog::Monkey API, but as a deprecated module that does nothing. Instead it prints deprecation warnings to the logs, advising users to upgrade their implementation.

This module will be removed again in future versions. Users should upgrade to the new configuration API before then:

https://github.com/DataDog/dd-trace-rb/releases/tag/v0.11.0

W, [2018-02-02T13:26:38.921334 #20208]  WARN -- ddtrace: [ddtrace] Monkey#autopatch_modules:
      Datadog::Monkey has been REMOVED as of version 0.11.1.
      All calls to Datadog::Monkey are no-ops.
      *Implementations using Monkey will no longer function*.
      Upgrade to the new configuration API using the migration guide here:
      https://github.com/DataDog/dd-trace-rb/releases/tag/v0.11.0

@delner delner added bug Involves a bug core Involves Datadog core libraries breaking-change Involves a breaking change labels Feb 2, 2018
@delner delner self-assigned this Feb 2, 2018
@palazzem palazzem added this to the 0.11.2 milestone Feb 2, 2018
@delner delner removed the breaking-change Involves a breaking change label Feb 2, 2018
p-lambert
p-lambert previously approved these changes Feb 2, 2018
View reviewed changes
test/monkey_test.rb

def setup
@buf = StringIO.new
Datadog::Tracer.log = Datadog::Logger.new(@buf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

palazzem
palazzem previously approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go as the CI is green. Let's:

  • merge this one on master
  • ship a new 0.11.2 release on top of this branch

@delner delner dismissed stale reviews from palazzem and p-lambert via 5ffcd94 February 2, 2018 19:10
@delner delner force-pushed the delner/revert_monkey_removal branch from e606d52 to 5ffcd94 Compare February 2, 2018 19:10
@delner delner mentioned this pull request Feb 2, 2018
Merged
palazzem
palazzem approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already released in the current 0.11.2 release so it's safe to be merged in the current master.

@palazzem palazzem merged commit 73e5b2f into master Feb 5, 2018
@palazzem palazzem deleted the delner/revert_monkey_removal branch February 5, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

@p-lambert p-lambert p-lambert approved these changes

Assignees

@delner delner

Labels
bug Involves a bug core Involves Datadog core libraries
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.
3 participants
@delner @p-lambert @palazzem