[NO-TICKET] Import upstream rb_profile_frames fix
#3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR imports an upstream fix to `rb_profile_frames` from ruby/ruby#9310 into our own custom copy of that function. **Motivation:** As explained in the comment, the situation being handled does not yet happen with dd-trace-rb in practice since we don't support profiling with MN threads enabled, but since we want to try supporting it at some point, I've gone ahead and imported the fix. **Additional Notes:** N/A **How to test the change?** This is a bit awkward to test, so didn't add any coverage.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3352 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 1253 1253
Lines 73035 73035
Branches 3429 3428 -1
==========================================
- Hits 71749 71748 -1
- Misses 1286 1287 +1 ☔ View full report in Codecov by Sentry. |
AlexJF
approved these changes
Jan 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR imports an upstream fix to
rb_profile_framesfrom ruby/ruby#9310 into our own custom copy of that function.Motivation:
As explained in the comment, the situation being handled does not yet happen with dd-trace-rb in practice since we don't support profiling with MN threads enabled, but since we want to try supporting it at some point, I've gone ahead and imported the fix.
Additional Notes:
N/A
How to test the change?
This is a bit awkward to test, so didn't add any coverage.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.