Add install_signature to app-started #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
added
core
yshapiro-57
approved these changes
Dec 27, 2023
Qard
force-pushed
the
stephen.belanger/install-signature
branch
3 times, most recently
from
9a69447
to
7cbc0cd
Compare
Qard
force-pushed
the
stephen.belanger/install-signature
branch
from
7cbc0cd
to
bfb33dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3349 +/- ##
========================================
Coverage 98.23% 98.24%
========================================
Files 1253 1254 +1
Lines 73035 73172 +137
Branches 3429 3429
========================================
+ Hits 71749 71885 +136
- Misses 1286 1287 +1 ☔ View full report in Codecov by Sentry. |
ekump
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
install_signaturedata toapp-startedtelemetry event.Motivation:
Onboarding team wants visibility into success of different onboarding methods using a telemetry indicator.
Jira: Update Ruby library to handle install signature
How to test the change?
The test additions should cover this, but I'm a newbie to dd-trace-rb so may want to pay extra close attention to be sure I didn't miss anything. 😅
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.