-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove span operation aliases #3330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/remove-spand-id-alias
branch
from
December 14, 2023 17:25
76c6b6e
to
92384fa
Compare
marcotc
approved these changes
Dec 15, 2023
TonyCTHsu
force-pushed
the
tonycthsu/remove-spand-id-alias
branch
from
January 9, 2024 19:50
c52cc94
to
aa41c89
Compare
TonyCTHsu
force-pushed
the
tonycthsu/remove-spand-id-alias
branch
from
January 9, 2024 20:04
aa41c89
to
d43ff3b
Compare
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
span_type
ontrace
methodSpanOperation
andSpan
If you are accessing
SpanOperation
with manual instrumentation or pipeline processorsspan_op.span_id
tospan_op.id
span_op.span_type
tospan_op.type
span_op.span_type =
tospan_op.type =
For example:
Change
To
Additional notes
Temporary disable
graphql
test, because the instrumentation lives in https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/tracing/data_dog_tracing.rb