Fix potential crash by importing upstream rb_profile_frames fix
#3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR imports the changes from upstream ruby/ruby#8415 into our copy of `rb_profile_frames`. I'm not entirely sure if this crash could happen for ddtrace because unlike other Ruby profilers (like stackprof) we are not (yet?) sampling from the signal handler. **Motivation:** Make sure our `rb_profile_frames` matches upstream in terms of validation/safety. **Additional Notes:** N/A **How to test the change?** Good question -- I'll admit I don't quite know how to trigger the issue reported upstream. In any case, the change is quite small, so at most we'll report line 0 in a few cases where we previously weren't.
AlexJF
approved these changes
Dec 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR imports the changes from upstream
ruby/ruby#8415 into our copy of
rb_profile_frames.I'm not entirely sure if this crash could happen for ddtrace because unlike other Ruby profilers (like stackprof) we are not (yet?) sampling from the signal handler.
Motivation:
Make sure our
rb_profile_framesmatches upstream in terms of validation/safety.Additional Notes:
N/A
How to test the change?
Good question -- I'll admit I don't quite know how to trigger the issue reported upstream. In any case, the change is quite small, so at most we'll report line 0 in a few cases where we previously weren't.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.