Bump debase-ruby_core_source dependency to 3.2.3 #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR bumps our dependency on `debase-ruby_core_source` to version 3.2.3. This version is needed to support profiling Ruby 3.3.0-preview3. **Motivation:** Support profiling on Ruby 3.3.0-preview3. **Additional Notes:** I've updated the appraisal gemfiles as well. This PR unblocks #3259. **How to test the change?** Validate that CI is green.
As documented in `extconf.rb`, this flag can cause compilation failures because mkmf picks it up and uses it when calling `have_header`. For now I decided to disable it on 3.3, for fear it'll happen in 3.3.0-stable as well. We can revisit this later, and anyway for our own we get a lot of cover from the fact that all other Ruby versions still compile with this option enabled.
anmarchenko
approved these changes
Nov 27, 2023
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR bumps our dependency on
debase-ruby_core_sourceto version 3.2.3. This version is needed to support profiling Ruby 3.3.0-preview3.Motivation:
Support profiling on Ruby 3.3.0-preview3.
Additional Notes:
I've updated the appraisal gemfiles as well.
This PR unblocks #3259.
How to test the change?
Validate that CI is green.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.