Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel:Support reserved attribute overrides #3262

Merged
merged 1 commit into from
Nov 20, 2023
Merged

OTel:Support reserved attribute overrides #3262

merged 1 commit into from
Nov 20, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 15, 2023

What does this PR do?

This PR adds support for using reserved OpenTelemetry span attributes to override Datadog Span fields.

Normally, OpenTelemetry span attributes are simply converted to Datadog Span tags, but some attributes should change other properties of the Datadog Span:

  • "operation.name" => dd_span.name
  • "service.name" => dd_span.service
  • "resource.name" => dd_span.resource
  • "span.type" => dd_span.type
  • "analytics.event" => dd_span.set_metric("_dd1.sr.eausr")

How to test the change?

There are unit tests and system-tests for this change.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested review from a team as code owners November 15, 2023 22:53
@marcotc marcotc self-assigned this Nov 15, 2023
@marcotc marcotc merged commit b35933a into master Nov 20, 2023
207 of 218 checks passed
@marcotc marcotc deleted the otel-api-naming branch November 20, 2023 21:09
@github-actions github-actions bot added this to the 1.17.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants