Remove depends_on
from Core Configuration option
#3085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Based on internal conversations, we agreed that
depends_on
is a feature from the past and that is no longer used. It has been replaced with the different components. Because of that we agreed that it was good to remove it 🔥Motivation:
We are cleaning up the codebase from options we no longer use.
I was able to remove the following:
depends_on
option from the configuration DSLConfiguration::DependencyResolver
.Configuration::OptionDefinitionSet
. It was inherited from Hash, and the only functionality added was to organize the options in order using thedepends_on
attribute. I replaced it with a normal Hash.Configuration::OptionSet
. It was inherited from Hash, but we were not extending the class with any particular functionality. I replaced it with a normal Hash.Additional Notes:
How to test the change?
CI must be 🟢
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!