Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvironmentLogger adjustments #3057

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Aug 17, 2023

What does this PR do?
This PR includes two notable changes:

  • moves the Profiling call to EnvironmentLogger to the beginning of the method so that even if profiling is not enabled, the log will still print.
  • allows empty values to print in the hash output (previously, only non-empty values were returned).

Motivation
Discussion with the support team led to this change.

Additional Notes
This PR follows #3020.

How to test the change?
Testing this change is similar to testing #3020.

@github-actions github-actions bot added core Involves Datadog core libraries profiling Involves Datadog profiling tracing labels Aug 17, 2023
@sarahchen6 sarahchen6 force-pushed the refactor/extract_environment_logger_3 branch from b99ee89 to 6d35cad Compare August 17, 2023 14:27
@sarahchen6 sarahchen6 marked this pull request as ready for review August 17, 2023 17:31
@sarahchen6 sarahchen6 requested a review from a team August 17, 2023 17:31
@sarahchen6 sarahchen6 merged commit 0e7da21 into master Aug 17, 2023
163 checks passed
@sarahchen6 sarahchen6 deleted the refactor/extract_environment_logger_3 branch August 17, 2023 20:56
@github-actions github-actions bot added this to the 1.14.0 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries profiling Involves Datadog profiling tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants