Redis 4.0 support #305
Merged
Redis 4.0 support #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to keep in mind, I've found Redis 4.0 is not compatible with Ruby < 2.2.2 or Resque < 2.0. Resque 2.0+ is still currently unreleased, and when it is, they will drop support for all Ruby versions < 2.1. Related commits on Resque: |
delner
force-pushed
the
delner/redis_4_support
branch
3 times, most recently
from
b6b9940
to
d14e399
Compare
p-lambert
reviewed
Jan 12, 2018
| @@ -63,7 +53,8 @@ def patch_redis_client | |||
|
|
|||
| def initialize(*args) | |||
| service = Datadog.configuration[:redis][:service_name] | |||
| pin = Datadog::Pin.new(service, app: 'redis', app_type: Datadog::Ext::AppTypes::DB) | |||
| tracer = Datadog.configuration[:redis][:tracer] | |||
| pin = Datadog::Pin.new(service, app: 'redis', app_type: Datadog::Ext::AppTypes::DB, tracer: tracer) | |||
p-lambert
previously approved these changes
Jan 12, 2018
delner
force-pushed
the
delner/redis_4_support
branch
from
a6fc3e7
to
a6efab0
Compare
palazzem
approved these changes
Jan 17, 2018
There was a problem hiding this comment.
Since we're introducing a breaking change in the Configuration system, we can have this PR merged that removes the Pin accessors from the Redis client. The new way to change tracing configs is:
require 'redis'
require 'ddtrace'
Datadog.configure do |c|
c.use :redis, service_name: 'redis' # default service name
end
# traced clients
customer_cache = Redis::Client.new
invoice_cache = Redis::Client.new
# change service names for each client
Datadog.configure(customer_cache, service_name: 'customer-cache')
Datadog.configure(invoice_cache, service_name: invoice-cache')
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Redis patcher isn't compatible with Redis 4.0.
According to some of the latest changes, they removed backwards compatibility for using
Redis#clientas we were in our patcher. That function no longer returns a client object, instead we must use the newRedis#_clientfunction.Relevant commits here:
redis/redis-rb@c239abb
redis/redis-rb@3138507
This pull request adds an alternative patching method for Redis version 4+, which uses the new
Redis#_clientinstead. It also retains our older method of patching for Redis versions 3.x, to preserve backwards compatibility.