Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize active_record connection config #304

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Memoize active_record connection config #304

merged 1 commit into from
Jan 9, 2018

Conversation

p-lambert
Copy link
Member

@p-lambert p-lambert commented Jan 9, 2018 •
edited
Loading

Closes PR #222

@palazzem palazzem self-requested a review January 9, 2018 22:32
delner
delner approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@palazzem palazzem added enhancement integrations Involves tracing integrations labels Jan 9, 2018
@palazzem palazzem added this to the 0.11.0 milestone Jan 9, 2018
palazzem
palazzem approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@palazzem palazzem merged commit d1cb6fa into master Jan 9, 2018
@palazzem palazzem deleted the pedro/memoize-connection-config branch January 9, 2018 23:11
@palazzem palazzem mentioned this pull request Jan 11, 2018
Closed
@delner delner mentioned this pull request Mar 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner approved these changes

@palazzem palazzem palazzem approved these changes

Assignees
No one assigned
Labels
integrations Involves tracing integrations
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@p-lambert @palazzem @delner