Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document issue with Resque workers hanging #3033

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Aug 8, 2023

What does this PR do?:

This PR adds the "Resque workers hang on exit" issue discussed in #3015 to the "Known issues and suggested configurations" section of our docs.

Motivation:

This issue seems to come up a few times, e.g. in:

...so I've decided to document the issue and the best-known workaround so that other customers than unfortunately run into it may find our suggested solution.

Additional Notes:

N/A

How to test the change?:

Docs-only change.

**What does this PR do?**:

This PR adds the "Resque workers hang on exit" issue discussed in
#3015 to the
"Known issues and suggested configurations" section of our docs.

**Motivation**:

This issue seems to come up a few times, e.g. in:
* #466
* #2379
* #3015

...so I've decided to document the issue and the best-known workaround
so that other customers than unfortunately run into it may find our
suggested solution.

**Additional Notes**:

N/A

**How to test the change?**:

Docs-only change.
@ivoanjo ivoanjo requested a review from a team August 8, 2023 11:11
@github-actions github-actions bot added the docs Involves documentation label Aug 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3033 (8cd1f94) into master (b3f3a0a) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files        1317     1317           
  Lines       74362    74366    +4     
  Branches     3402     3402           
=======================================
+ Hits        72943    72947    +4     
  Misses       1419     1419           

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@anmarchenko anmarchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me and safe enough to approve on my first week :)

@ivoanjo
Copy link
Member Author

ivoanjo commented Aug 11, 2023

Thanks y'all for the review! 🙇

@ivoanjo ivoanjo merged commit f6d1668 into master Aug 11, 2023
@ivoanjo ivoanjo deleted the ivoanjo/document-resque-issue branch August 11, 2023 16:16
@github-actions github-actions bot added this to the 1.13.1 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants