-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hash log_tags warning #3022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/hash-log-tags-fix
branch
from
August 2, 2023 13:17
faad757
to
047e85d
Compare
marcotc
approved these changes
Aug 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #3022 +/- ##
==========================================
+ Coverage 98.08% 98.12% +0.03%
==========================================
Files 1317 1322 +5
Lines 74362 74622 +260
Branches 3402 3403 +1
==========================================
+ Hits 72941 73222 +281
+ Misses 1421 1400 -21
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
reviewed
Aug 8, 2023
marcotc
approved these changes
Aug 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip warning for log injection configuration when Semantic Logger's named tags override Rails built-in config.log_tags with a hash value