-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry:add app-client-configuration-change event #2977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but overall LGTM
Thank you, @GustavoCaso! |
Codecov Report
@@ Coverage Diff @@
## master #2977 +/- ##
==========================================
- Coverage 98.09% 98.08% -0.01%
==========================================
Files 1301 1305 +4
Lines 72574 72672 +98
Branches 3365 3368 +3
==========================================
+ Hits 71189 71283 +94
- Misses 1385 1389 +4
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR adds the telemetry event
app-client-configuration-change
, which reports that configuration at the Client Library (ddtrace
) has changed.This event captures the changes themselves and a change source (called
origin
in the event).The first use case is reporting changes from Dynamic Configuration. These have the origin
remote_config
.The changes are a list of 2-tuples (
List<String, Integer | Boolean | String>
) representing the configuration that was just set.One thing to noticed is that
app-client-configuration-change
is a Telemetry V2 event, butddtrace
currently implements Telemetry V1.To aid with the migration to V2, the Datadog backend supports a few V2 events through the V1 pipeline. This is one of them.
This PR does not actually report the new event, only creates the API to trigger this event.
This event is crucial to Dynamic Configuration because it reports back to Datadog that the changes have been applied successfully to the current Ruby process.