Add sampling configuration by DD_TRACE_SAMPLING_RULES #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
approved these changes
Jul 14, 2023
GustavoCaso
reviewed
Jul 14, 2023
| # @return [String,nil] | ||
| # @public_api | ||
| option :rules do |o| | ||
| o.default { ENV.fetch(Configuration::Ext::Sampling::ENV_RULES, nil) } |
There was a problem hiding this comment.
Isn't ENV.fetch(Configuration::Ext::Sampling::ENV_RULES, nil) the same as ENV[Configuration::Ext::Sampling::ENV_RULES]?
There was a problem hiding this comment.
Yeah, we just write ENV.fetch(blah, nil) more than ENV#[] in this file.
I feel like this will mostly go away when we refactor configuration 😉
There was a problem hiding this comment.
I'll leave this one like this, because it will be simple to refactor when this code gets simplified in the configuration refactoring.
GustavoCaso
reviewed
Jul 14, 2023
GustavoCaso
reviewed
Jul 14, 2023
GustavoCaso
reviewed
Jul 14, 2023
GustavoCaso
reviewed
Jul 14, 2023
marcotc
commented
Jul 14, 2023
| sample_rate: sample_rate, | ||
| } | ||
|
|
||
| Core::BackportFrom24.hash_compact!(kwargs) |
There was a problem hiding this comment.
I don't like how this BackportFrom comes in right in the middle of the method, can we start using refinements again? 🙏
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for configuring the
RuleSamplerusing the environment variableDD_TRACE_SAMPLING_RULES.This is already supported by most tracers of other languages.
This environment variable is a JSON array of objects, with each object being of the format:
{ "sample_rate": 0.123, "name": "span.name", "service": "service-name" }The supporting feature,
RuleSampler, already exists; this PR only adds an additional configuration avenue.