Fix profiler libmysqlclient version detection with mysql2-aurora gem #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR tweaks the libmysqlclient version detection code added in #2770 to also work when the `mysql2-aurora` gem is in use. **Motivation**: The way that the mysql2-aurora gem installs itself leads to the "no signals" workaround (#2873) being incorrectly enabled for customers that do have a modern version of libmysqlclient. **Additional Notes**: The mysql2-aurora gem likes to monkey patch itself in replacement of `Mysql2::Client`, and uses `method_missing` to delegate to the original BUT unfortunately does not implement `respond_to_missing?` and thus one of our checks (`respond_to?(:info)`) was incorrectly failing. **How to test the change?**: This change includes code coverage. This can also be reproduced easily by adding the `mysql2-aurora` gem to the `Gemfile` and then running a trivial Ruby app: ``` $ DD_PROFILING_ENABLED=true DD_TRACE_DEBUG=true bundle exec ruby -e "require 'mysql2/aurora'; require 'datadog/profiling/preload'" # Before DEBUG -- ddtrace: [ddtrace] Requiring `mysql2` to check if the `libmysqlclient` version it uses is compatible with profiling WARN -- ddtrace: [ddtrace] Enabling the profiling "no signals" workaround because an incompatible version of the mysql2 gem is installed. Profiling data will have lower quality. To fix this, upgrade the libmysqlclient in your OS image to version 8.0.0 or above. # After DEBUG -- ddtrace: [ddtrace] Requiring `mysql2` to check if the `libmysqlclient` version it uses is compatible with profiling DEBUG -- ddtrace: [ddtrace] The `mysql2` gem is using a compatible version of the `libmysqlclient` library (8.0.33) ```
|
Also reported issue upstream: alfa-jpn/mysql2-aurora#13 |
marcotc
approved these changes
Jul 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR tweaks the libmysqlclient version detection code added in #2770 to also work when the
mysql2-auroragem is in use.Motivation:
The way that the mysql2-aurora gem installs itself leads to the "no signals" workaround (#2873) being incorrectly enabled for customers that do have a modern version of libmysqlclient.
Additional Notes:
The mysql2-aurora gem likes to monkey patch itself in replacement of
Mysql2::Client, and usesmethod_missingto delegate to the original BUT unfortunately does not implementrespond_to_missing?and thus one of our checks (respond_to?(:info)) was incorrectly failing.How to test the change?:
This change includes code coverage. This can also be reproduced easily by adding the
mysql2-auroragem to theGemfileand then running a trivial Ruby app: