-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Minitest CI integration #2932
Conversation
👋 @bravehager, thank you so much for the contribution! I'm pinging the CI team to get their 👀 here asap. Thank you again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks for this! ❤️
I've tested this end to end with the test suite in https://github.com/freeCodeCamp/devdocs and it works wonderfully.
Anything I can do to help get this merged? I see there's a CI check blocked but seems resolved by #2929, so might just need a merge or rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, @bravehager!
Could you add a section for Minitest documentation, similar to the RSpec one here: https://github.com/DataDog/dd-trace-rb/blob/master/docs/GettingStarted.md#rspec |
Codecov Report
@@ Coverage Diff @@
## master #2932 +/- ##
==========================================
- Coverage 97.96% 97.93% -0.03%
==========================================
Files 1282 1287 +5
Lines 70959 71052 +93
Branches 3265 3272 +7
==========================================
+ Hits 69512 69586 +74
- Misses 1447 1466 +19
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thank you so much for the documentation! I noticed one last thing: we have Could you follow the steps in the failure output and see if you can address it. If you find that the guide referenced there is insufficient please let us know so we can improve it. |
What does this PR do?
Add CI Visibility support for the Minitest framework.
Motivation
Datadog doesn't currently support using Minitest with the CI Visibility feature. It's easy enough to add your own custom integration, but I think it makes sense for
dd-trace-rb
to provide first-class support for Minitest given that it's the default testing framework for Ruby on Rails.Additional Notes
./
prefix for the test suite name. Right now, we're usingPathname.new(path).relative_path_from(Pathname.pwd).to_s
which doesn't include the./
prefix. Should we mirror the RSpec setup?minitest/unit
, I haven't dug into what it would take to supportminitest/spec
.I realize this is a pretty big patch that you might not want to accept from an outside contributor, but I figured I'd put together a PR since we've been using this internally.
How to test the change?