Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop invalid byte sequences on Redis::Quantize #289

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Drop invalid byte sequences on Redis::Quantize #289

merged 1 commit into from
Dec 22, 2017

Conversation

p-lambert
Copy link
Member

@p-lambert p-lambert commented Dec 21, 2017 •
edited
Loading

This PR ensures all byte sequences considered invalid/undefined in by UTF-8 are removed from redis spans before they get flushed.

delner
delner approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@p-lambert p-lambert merged commit 3c545c0 into master Dec 22, 2017
@palazzem palazzem added this to the 0.11.0 milestone Jan 17, 2018
@delner delner deleted the pedro/quantization-improv branch February 9, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@p-lambert @delner @palazzem