Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log injection hook to after_initialize #2882

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented May 31, 2023

What does this PR do?

This PR provides the changes required to configure rails log injection in after_initialize hook, so that it would respect the configuration from config/initializers/datadog.rb

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels May 31, 2023
@TonyCTHsu TonyCTHsu linked an issue May 31, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #2882 (ec19681) into master (544615c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2882      +/-   ##
==========================================
- Coverage   98.09%   98.08%   -0.01%     
==========================================
  Files        1301     1301              
  Lines       72574    72567       -7     
  Branches     3365     3359       -6     
==========================================
- Hits        71189    71180       -9     
- Misses       1385     1387       +2     
Impacted Files Coverage Δ
lib/datadog/tracing/contrib/rails/log_injection.rb 83.33% <100.00%> (-1.29%) ⬇️
lib/datadog/tracing/contrib/rails/patcher.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/change-log-injection-hook branch from 4fdcc8a to c1430d0 Compare June 30, 2023 09:20
@TonyCTHsu TonyCTHsu marked this pull request as ready for review July 5, 2023 19:44
@TonyCTHsu TonyCTHsu requested a review from a team July 5, 2023 19:44
@TonyCTHsu TonyCTHsu added this to the 1.13.0 milestone Jul 20, 2023
@TonyCTHsu TonyCTHsu merged commit d6fcf01 into master Jul 24, 2023
@TonyCTHsu TonyCTHsu deleted the tonycthsu/change-log-injection-hook branch July 24, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to disable log_injection
3 participants