Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set span types for integrations #286

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Set span types for integrations #286

merged 1 commit into from
Dec 21, 2017

Conversation

delner
Copy link
Contributor

@delner delner commented Dec 20, 2017

This pull request ensures we're correctly tagging our spans for each service integration, for a better UI experience. After these changes are applied, the following integrations should have these service and span types:

                  Service         Span
 X ActiveRecord  - DB              SQL::TYPE
 X AWS           - WEB             WEB
 X Dalli         - CACHE           CACHE
 X ElasticSearch - DB              DB
 X Faraday       - WEB             HTTP::TYPE
 X Grape         - WEB             HTTP::TYPE
 ? HTTP          - ???             HTTP::TYPE
 X MongoDB       - DB              Mongo::TYPE
 X Rack          - WEB             HTTP::TYPE
 X Rails         - WEB, CACHE, DB  HTTP::TYPE, HTTP::TEMPLATE, SQL::TYPE, CACHE
 X Redis         - DB              Redis::TYPE
 X Resque        - WORKER          WORKER
 X Sidekiq       - WORKER          WORKER
 X Sinatra       - WEB             HTTP::TYPE, HTTP::TEMPLATE
 X SuckerPunch   - WORKER          WORKER

@delner delner added the do-not-merge/WIP Not ready for merge label Dec 20, 2017
@delner delner self-assigned this Dec 20, 2017
@delner delner removed the do-not-merge/WIP Not ready for merge label Dec 20, 2017
@delner delner merged commit 7553934 into master Dec 21, 2017
@palazzem palazzem added this to the 0.11.0 milestone Jan 17, 2018
@palazzem palazzem added the integrations Involves tracing integrations label Jan 17, 2018
@delner delner deleted the delner/set_span_types branch February 9, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants