Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate cache metadata #284

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Truncate cache metadata #284

merged 2 commits into from
Jan 2, 2018

Conversation

p-lambert
Copy link
Member

This PR enforces a hard-limit on the meta-data that's embedded in spans generated by rails cache instrumentation.

I'm also lowering the maximum size of redis commands.

delner
delner approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@p-lambert p-lambert merged commit bcf6c79 into master Jan 2, 2018
@palazzem palazzem deleted the pedro/truncate-cache-metadata branch January 4, 2018 15:22
@palazzem palazzem added enhancement integrations Involves tracing integrations labels Jan 4, 2018
@palazzem palazzem added this to the 0.11.0 milestone Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner Awaiting requested review from delner

Assignees
No one assigned
Labels
integrations Involves tracing integrations
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@p-lambert @delner @palazzem