Remove disabled JRuby 9.2.8.0 testing setup #2683
Merged
+0
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: In #2572 we changed our CI setup to test only with JRuby 9.2.21.0, disabling JRuby 9.2.8.0. Prior to that change, we tested with both versions. At the time we decided to only disable the JRuby 9.2.8.0 testing, commenting it out. This PR actually removes all references to testing with JRuby 9.2.8.0. As a reminder, we recommend that all our customers use at least JRuby 9.2.21.0, and also recommend evaluating the move to JRuby 9.3, as the JRuby developers have marked JRuby 9.2 as end-of-life: <https://twitter.com/jruby/status/1611063274459566106>. **Motivation**: Avoid having leftover setup that's not in use. **Additional Notes**: N/A **How to test the change?**: Validate that CI is still green on all configurations.
marcotc
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
In #2572 we changed our CI setup to test only with JRuby 9.2.21.0, disabling JRuby 9.2.8.0. Prior to that change, we tested with both versions.
At the time we decided to only disable the JRuby 9.2.8.0 testing, commenting it out.
This PR actually removes all references to testing with JRuby 9.2.8.0.
As a reminder, we recommend that all our customers use at least JRuby 9.2.21.0, and also recommend evaluating the move to JRuby 9.3, as the JRuby developers have marked JRuby 9.2 as end-of-life: https://twitter.com/jruby/status/1611063274459566106.
Motivation:
Avoid having leftover setup that's not in use.
Additional Notes:
N/A
How to test the change?:
Validate that CI is still green on all configurations.