Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dalli instrumentation encoding issue #267

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

p-lambert
Copy link
Member

@p-lambert p-lambert commented Dec 6, 2017

Since memcached is frequently used to store marshaled objects and other blob types, the Ruby VM might interpret dalli request arguments as strings with incompatible encodings. This PR adds a safe-guard for that case.

@palazzem palazzem self-requested a review December 7, 2017 08:19
@palazzem palazzem added the integrations Involves tracing integrations label Dec 7, 2017
@palazzem palazzem added this to the 0.11.0 milestone Dec 7, 2017
@palazzem palazzem merged commit 8393f05 into master Dec 7, 2017
@palazzem palazzem deleted the pedro/dalli-encoding-fix branch December 7, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants