Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better default names for rails services #264

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

p-lambert
Copy link
Member

@p-lambert p-lambert commented Dec 1, 2017

Instead of using static defaults (rails-app, rails-controller), we prepend the Rails app name to that value. The app name is retrieved using ::Rails.application.class if you didn't set it. In both cases, you'll have:

intake
intake-controller
intake-cache
...

You can still override each value if you want to keep different names than the ones provided by default.

@p-lambert p-lambert force-pushed the pedro/better-defaults-for-rails branch from d981132 to 0809c11 Compare December 1, 2017 21:44
Copy link
Contributor

@ufoot ufoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, indeed this would be more useful.

But we need to make obvious in the release docs as this is a breaking change to some extent. Indeed, it might change the name of services for all those who did not override it, and this is going to start a new set of stats, with new metrics, dashboards, where "day 0" will be the time this version has been installed. The old rails services will appear as if they disappeared.

@palazzem palazzem added breaking-change Involves a breaking change integrations Involves tracing integrations labels Dec 4, 2017
@palazzem palazzem added this to the 0.11.0 milestone Dec 4, 2017
@palazzem palazzem self-requested a review December 4, 2017 07:30
@dasch
Copy link
Contributor

dasch commented Dec 4, 2017

👍 ❤️

@palazzem palazzem merged commit 982e5e9 into master Dec 4, 2017
@palazzem palazzem deleted the pedro/better-defaults-for-rails branch December 4, 2017 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Involves a breaking change integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants