Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rack and rails services #263

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

p-lambert
Copy link
Member

@p-lambert p-lambert commented Dec 1, 2017

This PR puts rack and rails-controller spans under the same service name by default. For distinct service names, use the controller_service option as it follows:

Datadog.configure do |c|
  c.use :rails, service_name: 'rack-handler', controller_service: 'rails-controller'
end

Breaking change

It's worth mentioning this is a breaking change since it will affect metrics associated with rails controllers and rack middleware, so make sure to update any monitors that rely on these services, or use the controller_service option to have the same name you're using now.

@p-lambert p-lambert force-pushed the pedro/merge-rack-and-rails-services branch from 436ba9d to b7d8da0 Compare December 1, 2017 17:58
@p-lambert p-lambert force-pushed the pedro/merge-rack-and-rails-services branch from b7d8da0 to 56d52b5 Compare December 1, 2017 18:33
@palazzem palazzem added the integrations Involves tracing integrations label Dec 1, 2017
@palazzem palazzem added this to the 0.11.0 milestone Dec 1, 2017
@palazzem palazzem self-requested a review December 1, 2017 19:07
@palazzem palazzem added the breaking-change Involves a breaking change label Dec 1, 2017
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! thanks for this update.

@palazzem palazzem merged commit 84fe292 into master Dec 1, 2017
@palazzem palazzem deleted the pedro/merge-rack-and-rails-services branch December 1, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Involves a breaking change integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants