Fix NoMethodError when running Datadog.configure after only requiring core
#2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng core The fix in #1998, specifically in 2e5d1ee broke using `datadog/core` directly without `require 'ddtrace'`. For instance: ``` bundle exec ruby -e "require 'datadog/core'; Datadog.configure { }" Traceback (most recent call last): 9: from -e:1:in `<main>' 8: from .../lib/datadog/core/configuration.rb:89:in `configure' 7: from .../lib/datadog/core/configuration.rb:223:in `safely_synchronize' 6: from .../lib/datadog/core/configuration.rb:223:in `synchronize' 5: from .../lib/datadog/core/configuration.rb:225:in `block in safely_synchronize' 4: from .../lib/datadog/core/configuration.rb:94:in `block in configure' 3: from .../lib/datadog/core/configuration.rb:243:in `build_components' 2: from .../lib/datadog/core/configuration.rb:243:in `new' 1: from .../lib/datadog/core/configuration/components.rb:345:in `initialize' .../lib/datadog/core/configuration/components.rb:202:in `build_profiler': undefined method `supported?' for Datadog::Profiling:Module (NoMethodError) ``` As a workaround, I've added a `require 'datadog/profiling'` in `build_profiler`: this avoids re-adding the circular dependency issue, but fixes this use-case. Additionally, I've made is such that profiling is only loaded if it is enabled, which means that customers not using it will not need to load it, which is a nice bonus vs what we did prior to #1998.
Codecov Report
@@ Coverage Diff @@
## master #2008 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1008 1008
Lines 51143 51145 +2
=======================================
+ Hits 50023 50025 +2
Misses 1120 1120
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
marcotc
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #1998, specifically in 2e5d1ee broke using
datadog/coredirectly withoutrequire 'ddtrace'.For instance:
As a workaround, I've added a
require 'datadog/profiling'inbuild_profiler: this avoids re-adding the circular dependency issue, but fixes this use-case.Additionally, I've made is such that profiling is only loaded if it is enabled, which means that customers not using it will not need to load it, which is a nice bonus vs what we did prior to #1998.