Add better error messages when flaky tests fail #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is flaky, see for instance <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/3112/workflows/51134bcc-d765-420e-a2ea-e64b00278ade/jobs/124412> so let's add some extra information that can guide us to fix the cause whenever it fails. Here's an example of how it looks when it fails (in this case, I left the `Gemfile` open): ``` Open fds before: {"/dev/fd/0"=>"/dev/pts/0", "/dev/fd/1"=>"/dev/pts/0", "/dev/fd/2"=>"/dev/pts/0", "/dev/fd/3"=>nil, "/dev/fd/4"=>nil, "/dev/fd/5"=>nil, "/dev/fd/6"=>nil, "/dev/fd/7"=>nil} Open fds after: {"/dev/fd/0"=>"/dev/pts/0", "/dev/fd/1"=>"/dev/pts/0", "/dev/fd/2"=>"/dev/pts/0", "/dev/fd/3"=>nil, "/dev/fd/4"=>nil, "/dev/fd/5"=>nil, "/dev/fd/6"=>nil, "/dev/fd/7"=>"/app/Gemfile", "/dev/fd/8"=>nil} ```
This test is flaky, see for instance <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/3112/workflows/51134bcc-d765-420e-a2ea-e64b00278ade/jobs/124400> so let's add some extra information that can guide us to fix the cause whenever it fails.
marcotc
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cathttps://www.youtube.com/watch?v=amYzBQMT4VI| sed 's/snakes/flaky tests/' | sed 's/plane/CI/'