fix:Convert custom setting value to string for startup log #1109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that integration settings that can store arbitrary values, e.g.
"integration_rack_application"
, don't expand into a large payload like:We currently call
to_json
on our startup log hash, thus callingto_hash
on each object.Because objects can have custom
to_json
handlers, it is not safe to perform that call.For a Rails application, for example, you can get a
SystemStackError
due to recursive object resolution duringto_json
.Instead they create a less descriptive, yet safer output using
#to_s
:"integration_rack_application":"#RailsApp::Application:0x00007fde60c43bc8"