Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Sidekiq client middleware is same for clients & servers #1099

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Ensure Sidekiq client middleware is same for clients & servers #1099

merged 1 commit into from
Jul 10, 2020

Conversation

drcapulet
Copy link
Contributor

No description provided.

@drcapulet drcapulet requested a review from a team June 29, 2020 21:02
@marcotc
Copy link
Member

marcotc commented Jul 8, 2020 •
edited
Loading

Thank you very much for this work, @drcapulet!
One thing missing before we can merge are tests for this change.

I've recently merged #1092, which migrated our Sidekiq tests from Minitest to RSpec, so testing should be much easier now.

@marcotc marcotc added community Was opened by a community member integrations Involves tracing integrations labels Jul 9, 2020
marcotc
marcotc approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @drcapulet! Changes look good 👍

@marcotc marcotc merged commit c9f1d0f into DataDog:master Jul 10, 2020
@marcotc marcotc added this to the 0.38.0 milestone Jul 10, 2020
@jmbehr jmbehr mentioned this pull request Jul 13, 2020
Closed
@DocX DocX mentioned this pull request Jul 15, 2020
Closed
@drcapulet drcapulet deleted the alexc-sidekiq branch June 15, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

Assignees
No one assigned
Labels
community Was opened by a community member integrations Involves tracing integrations
Projects
None yet
Milestone
0.38.0
Development

Successfully merging this pull request may close these issues.
2 participants
@drcapulet @marcotc