Fix #configure forcing all options to eager load #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
force-pushed
the
fix/configure_eager_loading_lazy_vars
branch
from
2d50cbf to
743ac79
Compare
delner
force-pushed
the
fix/configure_eager_loading_lazy_vars
branch
from
743ac79 to
ec7e7c8
Compare
delner
added
bug
marcotc
pushed a commit
that referenced
this pull request
May 11, 2020
…y_vars Fix #configure forcing all options to eager load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1032
When configuring,
Contrib::Configuration::Settingswere effectively eager loading their configuration options in dependency order, which lead to unintended side effects like caching settings that were unwanted.This pull request removes the eager evaluation so that values do not erroneously cache.