Merge pull request #915 from DataDog/bug/sync-writer-stop

Add SyncWriter#stop method
DataDog · Jan 10, 2020 · f9408eb · f9408eb
2 parents 0a2bb4a + 1c1af27
commit f9408eb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/ddtrace/sync_writer.rb b/lib/ddtrace/sync_writer.rb
@@ -41,6 +41,12 @@ def write(trace, services = nil)
       Logger.log.debug(e)
     end
 
+    # Added for interface completeness
+    def stop
+      # No cleanup to do for the SyncWriter
+      true
+    end
+
     private
 
     def perform_concurrently(*tasks)

diff --git a/spec/ddtrace/sync_writer_spec.rb b/spec/ddtrace/sync_writer_spec.rb
@@ -100,6 +100,11 @@
     end
   end
 
+  describe '#stop' do
+    subject(:stop) { sync_writer.stop }
+    it { is_expected.to eq(true) }
+  end
+
   describe 'integration' do
     context 'when initializing a tracer' do
       subject(:tracer) { Datadog::Tracer.new(writer: sync_writer) }