-
Notifications
You must be signed in to change notification settings - Fork 373
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Expose development docker container ports to localhost only
**What does this PR do?**: This PR modifies our `docker-compose.yml` files to bind any ports on the development docker containers only for access by the host machine. This should not impact any development use-cases. **Motivation**: If the ports are not bound to localhost, they could potentially be accessed by other machines in the same network, which is not a great idea. **Additional Notes**: (N/A) **How to test the change?**: Check that running tests using `docker-compose` still works, as well as running them from your development machine directly.
- Loading branch information
Showing
5 changed files
with
15 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ services: | |
expose: | ||
- "80" | ||
ports: | ||
- "80:80" | ||
- "127.0.0.1:80:80" | ||
stdin_open: true | ||
tty: true | ||
volumes: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters