Add a bit more context to need for ruby2_keywords

DataDog · Apr 13, 2022 · aef2724 · aef2724
1 parent 2e1082a
commit aef2724
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/ddtrace/version.rb b/lib/ddtrace/version.rb
@@ -13,6 +13,8 @@ module VERSION
 
     # A maximum version was initially added in https://github.com/DataDog/dd-trace-rb/pull/1495 because we expected
     # the `ruby2_keywords` method to be removed (see the PR for the discussion).
+    # That is because Ruby 3.x support as implemented using `*args` needs `ruby2_keywords` to continue working,
+    # but if `ruby2_keywords` gets removed we would need to change the code to use `*args, **kwargs`.
     #
     # Now Ruby 3.2.0-preview1 is out and `ruby2_keywords` are still there, and there's even a recent change for it
     # in https://github.com/ruby/ruby/pull/5684 that is documented as "ruby2_keywords needed in 3.2+".